pendulum-chain / spacewalk-testing-service

GNU General Public License v3.0
0 stars 0 forks source link

1 create service for periodic spacewalk vault client integration tests #2

Closed gianfra-t closed 11 months ago

gianfra-t commented 11 months ago

Implementation

High Level Overview:

Things that will probably be left for a future issue

gianfra-t commented 11 months ago

Hey @ebma, could you please convert this into a draft? It seems like I don't have team access to do it.

ebma commented 11 months ago

I actually can't because it's not available for private repos with our current Github plan. 🫥

image
gianfra-t commented 11 months ago

Ohh then no problem, it is not at all important!

gianfra-t commented 11 months ago

Sure!, I'm okay with those changes. As for the errors, actually I removed them because everything was going to slack, but we can add a log of whatever would be sent to slack so we can debug without creating/installing the slack app.

ebma commented 11 months ago

Did you use prettier for the formatting or another tool? We should add some command to the package.json that handles formatting/linting the code and maybe also configure a pre-commit hook

gianfra-t commented 11 months ago

I am using prettier now! (for the last commit). We could use the same hook as in the squids repo probably.

ebma commented 11 months ago

Yes, let's add the same hook 👍 IIRC I used option 1) described here to add it to the squid repo.

ebma commented 11 months ago

Merging this now as all features we wanted are ready.