pendulum-chain / spacewalk

Apache License 2.0
34 stars 7 forks source link

Re-run benchmarks for custom pallets #497

Closed bogdanS98 closed 5 months ago

bogdanS98 commented 6 months ago

Closes #496.

~Still WIP as running benchmarks for vault-registry pallet results in panic:~

~at: spacewalk/pallets/vault-registry/src/benchmarking.rs:154 Error: Input("Error executing and verifying runtime benchmark: Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some(\"ExceedingVaultLimit\") })") Evicting failed runtime instance error=Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some("ExceedingVaultLimit") })~

Fixed vault-registry benchmarks panic by setting the issue amount from 10000 to 5000 here.

ebma commented 6 months ago

What's the error in the panic?

bogdanS98 commented 6 months ago

What's the error in the panic?

at: spacewalk/pallets/vault-registry/src/benchmarking.rs:154 Error: Input("Error executing and verifying runtime benchmark: Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some(\"ExceedingVaultLimit\") })") Evicting failed runtime instance error=Runtime panicked: called Result::unwrap() on an Err value: Module(ModuleError { index: 21, error: [1, 0, 0, 0], message: Some("ExceedingVaultLimit") })

b-yap commented 5 months ago

I cancelled the CI since there's another one running. I'll rerun it afterwards.