search

pendulum-chain / spacewalk

Apache License 2.0
34 stars 7 forks source link

471 clean up stellar secret keys #504

Closed gianfra-t closed 5 months ago

gianfra-t commented 5 months ago

Closes #471

Makes use of environmental variables for the stellar secret keys instead of reading them from the resources files, when running tests. We don't use clap for passing the keys given that is not straightforward to use with cargo test.

We maintain the usage of the same cli commands where we specify the stellar_vault_secret_key_filepath, but use the environment keys for testing.

The use of DEFAULT_MAINNET_DEST_SECRET_KEY and DEFAULT_TESTNET_DEST_SECRET_KEY is now replaced by destination keys read from environment. In order to keep the use of only 4 consistent source and destination keys, the keys previously supplied from by these constants are changed.

NOTE: the tests should be failing until we add the github secrets corresponding to the stellar keys.

gianfra-t commented 5 months ago

@ebma Thanks for the comments. After I change the code for the suggestions I think I can "migrate" the accounts. Just to verify, all 4 accounts need to have the same trustliness and the only difference is that source accounts will have the asset in question right? Also, all 4 need some amount of lumen.