Test Case `stellar_overlay_should_receive_scp_messages` fails

[b-yap]

This test case: https://github.com/pendulum-chain/spacewalk/blob/ea66a3062e6edf05a4ed7b377f107e1f95b688f1/clients/stellar-relay-lib/src/tests/mod.rs#L42-L67

failed twice:

failures:

---- tests::stellar_overlay_should_receive_scp_messages stdout ----
thread 'tests::stellar_overlay_should_receive_scp_messages' panicked at clients/stellar-relay-lib/src/tests/mod.rs:66:5:
assertion failed: !scps_vec.lock().await.is_empty()

See https://github.com/pendulum-chain/spacewalk/actions/runs/8980428758/job/24674454969?pr=513#step:12:510 https://github.com/pendulum-chain/spacewalk/actions/runs/8980428758/job/24672556732?pr=513#step:12:509

Investigate whether the test case only needs an update, or an update of the config file is required.

[prayagd]

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

[gianfra-t]

I see that this test works at least in the latest runs. Maybe it was solved by changing the config file?

[bogdanS98]

@gianfra-t There was at least one config file change in the last 2 months (e.g. this) and this ticket's description was last updated on May 7th which is way before that. I also think this is solved already by the new config file changes.

[ebma]

Would be great if this got fixed automatically. @gianfra-t did you notice the test case failing in any of your comments of the https://github.com/pendulum-chain/spacewalk/pull/550 PR? If that's not the case I would be confident enough to close this ticket.

[gianfra-t]

Actually, no. Latest tests are failing due to format issues, or random compilation issues. So I think it is fixed.

[ebma]

Nice 🙏 @b-yap since you created the ticket and found the issue I'd like you to have the last word. If you agree that this seems to be solved please go ahead and close this ticket.

[b-yap]

I agree.