pendulum-chain / spacewalk

Apache License 2.0
34 stars 7 forks source link

Fix pre-commit and pre-push hooks #525

Open ebma opened 2 months ago

ebma commented 2 months ago

Following up to the changes made in #513, we need to modify our pre-commit and pre-push hooks. The problem is that the pre-commit hook will run rustfmt using the stable toolchain (as that's the one defined in the rust-toolchain.toml file) but the check in CI performs the check using a nightly toolchain, see here.

The problem with the pre-push hook is that it's not performing the same checks as we have in the workflow file anymore.

TODO

ebma commented 2 months ago

@pendulum-chain/product this only improves our developer experience and doesn't add any new features. It's quite annoying though, so I'd appreciate if someone can work on this soon.