pendulum-chain / spacewalk

Apache License 2.0
34 stars 7 forks source link

Make issue pallet benchmarks run successfully on Pendulum runtimes #528

Closed bogdanS98 closed 3 months ago

bogdanS98 commented 3 months ago

Context

The problem is that on the testchain runtime, we are defining the relay chain currency ID for the griefing collateral, see here. On our actual production runtimes we use the native currency. Since these calls only mint the 'collateral token' into the accounts used for benchmarking and not the native token, the call to requestIssue() fails to lock the griefing collateral in the native currency. As we want to keep having the griefing collateral denoted in the native currency, we should change the benchmark logic so that also the 'griefing collateral currency' token is minted here.

In addition to this, we should have the amount used in the benchmark here match the 'minimum transfer amount' here so that we don't get AmountBelowMinimumTransferAmount error when running the benchmarks.

Requirement

Provide fixes for all of the above and re-run benchmarks for issue pallet on Spacewalk

ebma commented 3 months ago

In addition to this, we should have the amount used in the benchmark here match the 'minimum transfer amount' here so that we don't get AmountBelowMinimumTransferAmount error when running the benchmarks.

Might make sense to also check if we can/should add the same improvement to other pallets ie. redeem and replace @bogdanS98.