pendulum-chain / spacewalk

Apache License 2.0
34 stars 7 forks source link

#538 shutdown the `OracleAgent` at `VaultService` level #539

Closed b-yap closed 2 months ago

b-yap commented 2 months ago

Addresses #538.

In the logs, the try_shutdown_wallet() logs just fine, so I plan to do the same thing for OracleAgent. To do this, the agent has to be accessible at the VaultService level. So I added anagent field in VaultService.

I removed subscription of the ShutdownSender because of its erratic behavior in the OracleAgent; sometimes it works, sometimes it doesn't.

b-yap commented 2 months ago

fetch_transactions_iter_success is failing on testnet. I changed to Public network, and it ran just fine. :no_mouth:

ebma commented 2 months ago

You tested that change locally @b-yap? How annoying.

b-yap commented 2 months ago

@ebma Yes I tested it locally, but analyzed and found faults in the code, so I updated it. :+1: