pendulum-chain / spacewalk

Apache License 2.0
35 stars 7 forks source link

Make vault clients export metrics with default values if no data is available #548

Closed ebma closed 2 weeks ago

ebma commented 2 months ago

Context

When a vault client is running for a liquidated vault, some data is not exported anymore. This makes it difficult for the monitoring services to work properly as 'no data' would generally be considered a bug or faulty. To facilitate the monitoring and alerting of our vault clients we should change this to rather return a default value of instead.

TODO

We want to change the vault clients to keep exporting data for the following metrics, even if the vault is liquidated:

For the metrics that are not applicable for liquidated vaults, namely locked and required collateral as well as collateralization, we should return 0 instead. For the others, we can keep exporting the correct values.

ebma commented 2 months ago

@pendulum-chain/product this ticket helps improve our automated alerts as it allows to monitor vaults even when they are liquidated.

prayagd commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

gianfra-t commented 2 weeks ago

@ebma all the listed fields show no data right now? For instance, even the redeem count for a liquidated vault.