search

pendulum-chain / substrate-stellar-sdk

A Rust SDK for Stellar that can be used for Substrate projects
Apache License 2.0
11 stars 11 forks source link

Resign unverified commits #24

Closed b-yap closed 9 months ago

b-yap commented 11 months ago

This is just to sign all unverified commits. Not sure how to force push/merge to master, to remove the "unverified commits".

Please ignore the "11 changed files"; Both this branch and master is the same.

See hex of master: https://github.com/pendulum-chain/substrate-stellar-sdk/blob/740389c7ec47a8725c32d8a68061ffb1bdfd013b/Cargo.toml#L16

See the implementation of StellarTypeToString for public key: https://github.com/pendulum-chain/substrate-stellar-sdk/blob/740389c7ec47a8725c32d8a68061ffb1bdfd013b/src/public_key.rs#L33-L52

transaction set impl: https://github.com/pendulum-chain/substrate-stellar-sdk/blob/master/src/xdr/impls/transaction_set.rs

transaction set type impl: https://github.com/pendulum-chain/substrate-stellar-sdk/blob/master/src/xdr/impls/transaction_set_type.rs

TorstenStueber commented 10 months ago

@b-yap I also don't know what the best course of action is here and I am not sure whether this is really possible. I would find it acceptable to leave the unverified commits as they are and just ensure that future commits are verified.