Change the text in the fees section

prayagd commented 2 months ago

Context

Currently the text in the fees section is not correct and should be changed to the following mentioned in the ticket

Requirement

Remove "0 EUR is what you will receive, after fees" and replace with "Details", also remove the text "show fees"
Show "Your quote" with the Nabla quote amount, show the actual quote next to this text in brackets and not under the output field
Change "Total fees" to "Offramp fees"
Remove the gas icon that is displayed before the amount
Show "Final Amount", this is Your quote - offramp fees. Show the same amount in the output field of EUR too

Note

The Offramp fees should be calculated by taking 1.25% of number of "Your quote"
The Offramp fees should be in the terms of the output currency selected by the user, for this instance its EUR

Design Reference

vadaynujra commented 2 months ago

@prayagd don't think we want to use the word Anchor here as it's not a standard industry term. Also, this fee should be specific to each off ramping currency and not standard across all (as each anchor has it's own different fees).

prayagd commented 2 months ago

@prayagd don't think we want to use the word Anchor here as it's not a standard industry term. Also, this fee should be specific to each off ramping currency and not standard across all (as each anchor has it's own different fees).

You are right, what would be a better wording offramp fees?

prayagd commented 2 months ago

Have updated it to offramp fees, let me if you got any other suggestion.

TorstenStueber commented 2 months ago

@prayagd the "total fees" (that is to be changed to "offramp fees") is defined how? This is a dollar amount at the moment but shouldn't it be in terms of the output currency?

prayagd commented 2 months ago

This is a dollar amount at the moment but shouldn't it be in terms of the output currency?

Good point @TorstenStueber and i agree see the offramp fees in dollar terms is might cause a bit confusion if higher amounts and user has to do then the conversion of the fees amount too. made changes in the ticket to show as per the output currency

prayagd commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz @TorstenStueber

ebma commented 2 months ago

@TorstenStueber do we want to support generic fees already ie. query the fee from the anchor data? Or only hard-code it for the each currency for the time being? I forgot if the charged fee is available from the anchor or not.

TorstenStueber commented 2 months ago

We could query it from the SEP24 endpoint but for the prototype I think it is fine to just hardcode it (that's what is happening now since this PR) as we also don't query any other information from the SEP24 info endpoint.

@prayagd The main confusion for me is that above the second input field we write "You receive" and in the fee box we write "... is what you will receive, after fees". So what do you receive?

The gas pump symbol is not clear to me: this indicates that we are talking about gas fees here but the fees deducted are not gas fees but anchor fees.

prayagd commented 2 months ago

@prayagd The main confusion for me is that above the second input field we write "You receive" and in the fee box we write "... is what you will receive, after fees". So what do you receive?

True we can remove the "You receive" from above the output field and just keep the "You receive in .... bank acount" in the fee section. that way user knows that its that amount.

The gas pump symbol is not clear to me: this indicates that we are talking about gas fees here but the fees deducted are not gas fees but anchor fees.

Agree thought of the same, added in the user story to remove that icon

ebma commented 2 months ago

Just to clarify/confirm my understanding of the changes in this ticket: We will still be showing two different numbers in the output field of the 'EUR' vs in the fees box?

How about we show the same number in the output field and the fees box (the final amount), and use the fees box only as a means to confirm to the user that it's the amount they will receive in the bank account, by using the text "You receive in .... bank account", and also show them the 'fee breakdown' (in this case just very basic, denoted as 'Offramping fees'). Otherwise, I feel like we still cause the same confusion we are trying to avoid.

TorstenStueber commented 2 months ago

This is a communication balancing act. The user will face both numbers in the anchor UI: this UI will typically provide 1) an input field at the end (which represents the first number, i.e., before anchor fees) and 2) will show the derived after-fee amount below (see screenshot).

I think it makes sense to already make them familiar with these two numbers in our UI, otherwise it is quite confusing:

if we mainly only show the number before fees, then they will wonder why they suddenly receive less than expected
if we mainly only show the number after fees, then the number in the input field (which they are free to change) does not make sense to them

I propose that we stop using an input field to display the output amount and instead show a simple cost breakdown, this makes the semantics more intuitive. Something like this:

The purpose to show the conversion rate for the output amount before fees is that we can make transparent that we offer a very low slippage and attractive conversion rate – one of the main USPs of Vortex.

ebma commented 2 months ago

Makes sense but how would you make the user able to select the target currency if we get rid of the input field for the output? It also contains the asset selector at the moment.

TorstenStueber commented 2 months ago

Yes, the asset selector needs to be put somewhere else of course. I didn't worry too much about it, we can put it anywhere close to the box in my screenshot, e.g., something like this:

https://jsfiddle.net/8w741f2p/1/

prayagd commented 2 months ago

Sorry but i dont agree to the suggestion by Torsten, removing the input field does not make sense breaks the UX as user wont know where to select the asset. and just keeping the asset selector somewhere on the screen is not ideal cc @Klausdmz can add more.

If the problem is about sharing two numbers, here is my suggestion. We keep the input field where the final number is shown in the input field itself and change the fees section just to denote the fees.

The only question is then what if the user adds this number to the input of MYKOBO, i know we are prefilling it but user might get confused there too right because that number would be the different from what we are showing on the screen.

TorstenStueber commented 2 months ago

There are two issues to solve here: a) where to put the select button for the target currency and b) how to make the two receiving amounts intuitive. I think the second problem is the bigger problem and I tried to solve that one with my proposal – at the same time and made the first issue bigger, I agree. However, if we just focus on the first issue and ignore the importance of the second, I would not consider that a proper solution.

Instead we could think about how to improve the placement of the selector of the target currency in my proposal.

Why does it break UX if the target currency selector is not inside an input field? In my opinion it just does not make sense to treat the input and output the same as the input is a single number that the user can edit and the output is actually two different amounts.

prayagd commented 2 months ago

Agree the second issue is bigger but that could be addressed and fixed by keeping the current designs and just changing the text, if i get it right the current confusing part is two "recieves" as this might confuse the user what exactly they are recieving, let me check with growth and get a better copy her. does that sound good?

TorstenStueber commented 2 months ago

How do you think the current design can fix it? I argued here that the current design only makes one of the two numbers prominent and leads to confusion in my opinion. As long as we don't break out of this and don't make both numbers prominent at the same time, I don't see this as a proper solution. Therefore a standard input field to show a single output value is not sufficient in my opinion.

prayagd commented 2 months ago

@pendulum-chain/devs as agreed in the tech-sync here is the new design, will update the main description too

prayagd commented 2 months ago

@TorstenStueber @ebma can you please add estimates?

Sharqiewicz commented 2 months ago

I still find it confusing that 1USDC.e = 0.89 EUR and the values of the inputs do not match this conversion rate. What do you think about changing the second input text from ‘You receive’ to ‘You receive (after fees)’?

prayagd commented 2 months ago

I like the suggestion, will make the change if other both agree too

ebma commented 2 months ago

Instead of changing it to '..(after fees)' we can also move the conversion rate into the 'Details' box as @TorstenStueber did in his suggestion here.

So the first line would be 'Your quote (1 USDC = 0.8937 EUR)'. This should make it clear that the exchange rate applies to the amount before/without the offramping fees.

pendulum-chain / vortex