Bugfix: transactions not dumped correctly

[TorstenStueber]

There is a regression in the logic to dump signed transactions. Instead of storing the actual transaction, only the literal name of the transaction variable is stored, e.g., nablaApproveTransaction, nablaSwapTransaction, ...

TODO

• dump the actual transactions instead of the variable names (this worked correctly initially)
• additionally it would be good to store some extra data such as input amount, output amount, and input and output tokens (this makes analyzing problems easier).

[TorstenStueber]

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @Sharqiewicz

[prayagd]

Dont estimate bugs, moving to ready

[gianfra-t]

Closing this as it is actually an unintended consecuence of a testing setup pointing to the same google sheet..

[gianfra-t]

I'll reopen this such that we append the additional amounts to the sheet here.

[ebma]

Ah right, nice catch and thanks for jumping in @gianfra-t. This would have been really difficult to pin down otherwise 😅 Let's still have a new ticket for the additional amounts as you would need to change both title and description of this ticket and in that case we can just create a new one.

[gianfra-t]

It was a very small change, I think. I pushed here. But I am not sure if we have to use a different sheet or just add the headers by hand is enough.

[ebma]

I added some handling for this and if the headers of the current sheet of the google doc don't match, then we'll just create a new sheet with those headers. So worst case, we'll end up with two sheets in the same document but we can resolve and merge that manually if this bothers us. So I don't see this as a blocker.

[TorstenStueber]

@gianfra-t if you use this issue here and don't create a new one can you please connect your branch?

[ebma]

Closing this ticket as the related PR is merged.