Duplication of Data in GTM

annatekl commented 2 months ago

Context:

We have identified an issue where the "Transaction Success" event is being pushed to the data layer twice. As a result, the event is captured twice in our Google Tag Manager (GTM) tool, leading to potential data inaccuracies and duplication in our analytics and reporting.

Steps to Reproduce:

Complete a transaction on the website.
Observe the data layer and note that the "Transaction Success" event is being pushed twice.
Check GTM and confirm that the event is being captured twice.

Screenshot:

Expected Behavior:

The "Transaction Success" event should only be pushed to the data layer once per transaction, ensuring that GTM captures the event a single time.

Wallet connect and disconnect events

Wallet connect and disconnect are being triggered multiple times on page refresh, causing duplication of data and double counting in analytics.

Steps to Reproduce:

Open the page vortex pmf version
Refresh the page without any action from the user.
Observe the data layer firing events for wallet connect and disconnect without user interaction. Screenshot

Requirement:

[ ] events should only be pushed once to the data layer
[ ] audit the data layer to ensure that the events are being sent correctly and are not duplicated.

gianfra-t commented 2 months ago

@pendulum-chain/product about events sent on connection and disconnection of the wallet, are we interested in registering if the user connects/disconnects multiple times intentionally?

annatekl commented 2 months ago

Hi @gianfra-t if thats the case then yes, but we saw this event being captured multiply times after page refresh was done and connect wallet wasn't performed. Additionally we are double counting transaction confirmation. We need to also check all the events we are sending, as currently apparently not all of them are send once only, hence the requirement to audit the data layer to ensure that the events are being sent correctly and are not duplicated.

annatekl commented 2 months ago

Hi @gianfra-t we were just testing the GTM and inspecting if events are correctly captured. What I did I connected the wallet, that was correctly captured then I refreshed the page and the wallet disconnect event was captured but the wallet was still connected. Are all events captured once only?

gianfra-t commented 2 months ago

It shouldn't happen. I cannot open the images attached, but were you testing on the staging branch? Since production doesn't have the changes still.

annatekl commented 2 months ago

the lastest link Torsten shared https://polygon-prototype--pendulum-pay.netlify.app/ , so that what you say will be life in production only?

gianfra-t commented 2 months ago

That would be production. This one https://polygon-prototype-staging--pendulum-pay.netlify.app/ should have the fix for the wallet event. Please check!

annatekl commented 1 month ago

Gianni, we just see that the failure is captured twice

gianfra-t commented 1 month ago

Hi Anna, thanks for detecting this one. Can you please share another image since I cannot see that one? That would help us check why it is detected twice, since in theory it shouldn't after this fix.

Also, lately there was a failed offramp but this was also in production, not staging. So if the duplicated failure entry refers to that one it is expected!

vadaynujra commented 1 month ago

@gianfra-t I believe @annatekl wanted to share this image.

gianfra-t commented 1 month ago

@vadaynujra @annatekl thanks for sharing the image. So it is confirmed this was seen using the staging deployment (https://polygon-prototype-staging--pendulum-pay.netlify.app/)? Since the recent failures where experienced in https://sp.gg which is production. If you recall you saw it staging I'll investigate.

annatekl commented 1 month ago

I was using this one https://polygon-prototype--pendulum-pay.netlify.app/ @vadaynujra and you?

pendulum-chain / vortex