pendulum-chain / vortex

1 stars 0 forks source link

Update CTA button text to make clearer #156

Closed prayagd closed 1 week ago

prayagd commented 2 weeks ago

Requirement

Implement the CTA button in the following way:

  1. After the user has input the amount they want to off ramp, the CTA for them reads - Confirm
  2. On clicking the button, it changes briefly (~0.5 secs) to Confirming (with a buffer sign), instead of Offramp in progress
  3. The next CTA should read Enter Details instead of Start Offramping
  4. On clicking the button, it should change to Processing Details (with a buffer sign), instead of Offramp in progress
vadaynujra commented 1 week ago

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz @TorstenStueber

TorstenStueber commented 1 week ago

Some remarks:

  1. Not just "After" but "While".
  2. So some text is only shown for 0.5 seconds? Users will barely be able to read this and this looks broken. But anyway, instead of a timer, we can just show the spinner as long as the sep24 initiation process happens in the background. I think that makes more sense.
vadaynujra commented 1 day ago

@Sharqiewicz @TorstenStueber looks like this change didn't land as expected. When I click Enter Details after Confirming the quote, the CTA should change to Processing Details (with a buffer sign), but at the moment it says Confirming (with the buffer sign). I didn't go through the whole anchor flow so it might get updated at a later point, but the req is for it to change to Processing Details immediately and until the user is back, so there shouldn't be a scenario of Confirming, after Enter Details.

image

vadaynujra commented 1 day ago

Looking at this comment now, and this design change might be intentional?

TorstenStueber commented 1 day ago

@vadaynujra you are right. I did not implement it correctly. I opened a new PR to fix that.