search

pendulum-chain / vortex

https://app.vortexfinance.co/
1 stars 1 forks source link

Fix transaction sheet dump always creating new sheet #158

Closed ebma closed 1 month ago

ebma commented 1 month ago

We recently noticed that the dumped data is always put into a new sheet. This is not ideal as it's more difficult to maintain and read the data.

This indicates that these lines are triggered and the check comparing the header values fails.

ebma commented 1 month ago

Wait, we don't estimate bug tickets. Nevermind the planning poker then, sorry.

gianfra-t commented 1 month ago

Fixed now. The code was fine, it is because the first sheet needs to have the headers we are sending. Values always tried to be appended to the first one. I reorganized the sheet and was able to verify by sending a mock transaction directly to the back-end.

ebma commented 1 month ago

Ahhhh okay, nice catch! Great that we didn't need any code changes to fix it. Though it would be nice if the backend wouldn't just check the first sheet for the matching header values, I guess it's good enough to know this limitation. I'm closing this as completed then.