Open TorstenStueber opened 1 week ago
Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @Sharqiewicz
@TorstenStueber Thanks for noticing these edge cases for NumericInput. I think they definitely need to be added to NumericInput.test.tsx
in Portal. I think we should make the changes in Portal as well. I have created a PR that fixes these errors and creates test cases here: https://github.com/pendulum-chain/portal/pull/561. Can we just copy this into Vortex?
The input field for the input amount has some clunky UX.
For example,
A mostly correct implementation of this logic is the
handleOnChangeNumericInput
function in the Portal.I say mostly correct because that implementation has unexpected results when a user enters "." when there is already a "." in the input:
TODO
Implement the input handling so that all cases above behave like as expected.