search

pendulum-chain / vortex

1 stars 0 forks source link

Fix input field bugs #166

Open gianfra-t opened 1 week ago

gianfra-t commented 1 week ago

Fixes #164.

Additionally, it fixes:

netlify[bot] commented 1 week ago

Deploy Preview for pendulum-pay ready!

Name Link
Latest commit 09073f2d61fde8964a2c7834e423f13c4d8e107c
Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/66edd424dea5820008b55d9d
Deploy Preview https://deploy-preview-166--pendulum-pay.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ebma commented 5 days ago

While unfortunate, I agree with @Sharqiewicz that it would be better first to fix the NumericInput field in the portal and then copy it over. The implementation used in the prototype originates from the portal but must be a version added prior to some improvements added to the portal input in the meantime. The input sanitization is overall easier to read in the NumericInput component of the portal IMO.

gianfra-t commented 5 days ago

@Sharqiewicz @ebma I'm okay to wait for the portal changes and then modify this. I think it still may be a bit different given how the consumers of the form in Vortex handle the value.

For instance, this part was not my first choice, yet it was important, otherwise the form would receive the uncleaned string (which lead to the empty string error when deleting fully the amount, for instance).

gianfra-t commented 5 days ago

@TorstenStueber I will wait to address your last comments until we have consensus on the previous comment.