Integrate ARS/Anclap into the offramp flow

pendulum-chain / vortex

https://app.vortexfinance.co/

1 stars 1 forks source link

Open prayagd opened 1 month ago

prayagd commented 1 month ago

This ticket enables ARS offramps.

Add ARS to the currency dropdown on the withdraw page, icon linked below
Extend the SEP-24 fee logic to allow for a relative and fixed fee
- define the proper fee parameters for ARS offramps: 2% relative fee and 10 ARS fixed fee
When user selects ARS as offramping currency and agrees to the quote
Add ARS as an output currency and define the output token configuration accordingly
Implement the Anclap anchor UI when the user selects ARS to offramp
Introduce a SEP-10 master account secret configuration for the signer service
- Use the corresponding account as the source account for SEP-10 when Anclap is used as the anchor
- In that case securely add the SEP-10 signature on the backend

gianfra-t commented 1 month ago

@pendulum-chain/product can this be worked already?

vadaynujra commented 1 month ago

Not till we have the asset live on Spacewalk and Forex AMM (with some col and liq respectively), which is why it is still in draft @gianfra-t

prayagd commented 1 month ago

@pendulum-chain/product can this be worked already?

I will get this ready and estimated till then

prayagd commented 1 month ago

@pendulum-chain/devs please check if the description is enough this to be estimated?

prayagd commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

gianfra-t commented 1 month ago

I'll assign myself to this since I can test the flow with my bank.

TorstenStueber commented 1 month ago

Just want to point out that ARS is not available yet on the AMM. But this should not be a blocker for this ticket here.

gianfra-t commented 1 month ago

Yes @TorstenStueber thanks. Since the changes are very small, I'll wait for ARS to be "ready" to work on this and test an off-ramp.

TorstenStueber commented 1 month ago

@gianfra-t FYI, this has been unblocked now as ARS is now available on Nabla: https://github.com/pendulum-chain/tasks/issues/401#issuecomment-2412361777

prayagd commented 3 weeks ago

@gianfra-t if and when you are unblocked for testing. please record the entire flow and share the recording

TorstenStueber commented 1 week ago

I incorporated the description of https://github.com/pendulum-chain/vortex/issues/173 into this issue and added a description of the SEP-10 master account so that this ticket here corresponds to the.