pendulum-chain / vortex

https://app.vortexfinance.co/
1 stars 1 forks source link

Revert splitting of Moonbeam receiver contract #185

Open ebma opened 1 month ago

ebma commented 1 month ago

Context

To work around issues introduced by the increase in gas cost on Moonbeam, the receiver contract was split into two parts for https://github.com/pendulum-chain/vortex/issues/137, resulting in additional overhead on the frontend application.

It seems like squidrouter managed to deploy a fix that works around this issue and the original logic would work again. To reduce the overhead, the splitting of the receiver contract should get reverted.

TODO

ebma commented 1 month ago

@pendulum-chain/product this change will also speed up the offramping process.

ebma commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @gianfra-t @Sharqiewicz @TorstenStueber

TorstenStueber commented 1 month ago

We should probably also test what Squidrouter did in the mean time. Do they really respect the estimatedGas parameters? Can we change this in the future if we need to (e.g., if Moonbeam changes their weight settings again?)

gianfra-t commented 1 month ago

I would personally leave the code around. Not as an automatic fallback since that would be quite a lot of work for a very unlikely scenario, but such that it's easy to plug the "new" logic back.

TorstenStueber commented 1 month ago

@gianfra-t so the suggestion would be to have a config parameter that determines what option we want to use? Could make sense that way.

ebma commented 1 month ago

Good point, I changed the description to reflect that.

vadaynujra commented 1 day ago

@ebma @TorstenStueber, Will the reduction of the overhead as a result of this change result in the off-ramp becoming quicker for the user? By how much would this change quicken flow?

TorstenStueber commented 1 day ago

Yes. About 10-20 seconds.

prayagd commented 1 day ago

@vadaynujra moved this ticket to being prepared in the light of current priority