pendulum-chain / vortex

https://app.vortexfinance.co/
1 stars 1 forks source link

Create sign-up flow for PendulumPay web app #2

Closed prayagd closed 7 months ago

prayagd commented 11 months ago

As a user, i should be able to sign-up the web app

Acceptance criteria

Note


### Standard secure Login/Signup flow
Due to GDPR we need to use secure practices that do not expose whether an email address is in our system.

### General principles

* all passwords are allowed, only requirement is minimum length, e.g., 8 or 10
   * **no other requirements (particularly no password rules like uppercase, lowercase, etc)**
   * (for a low priority feature we will implement later, we will check in the backend whether the password is common or has been pwned)
* passwords and emails are always normalized in backend (both for login and signup)
  *  password: trim whitespace at beginning and end
  *  email: trim whitespace at beginning and end, make everything lowercase
* passwords use a password hashing algorithm, the hashed passwords is a field of the user table in the database
  * e.g., bcrypt

### Lo-fi wireframes
![image](https://github.com/pendulum-chain/pendulum-pay/assets/52105313/de556da3-5a51-4b18-aaf7-e80e76eaea3a)
prayagd commented 11 months ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

prayagd commented 11 months ago

@pendulum-chain/devs also please raise any questions/ comments if anything unclear

ebma commented 11 months ago

Similar to what I mentioned here, we should not check for existing emails/passwords in the form validation and only do this after submitting the request to the backend.

Also, can we remove the email address verification for now? I don't think it's immediately needed but it makes the whole sign-up way more complex.

prayagd commented 11 months ago

Similar to what I mentioned https://github.com/pendulum-chain/pendulum-pay/issues/4#issuecomment-1838913203, we should not check for existing emails/passwords in the form validation and only do this after submitting the request to the backend.

Agree to this suggestion and made changes to the main description

Also, can we remove the email address verification for now? I don't think it's immediately needed but it makes the whole sign-up way more complex.

I think this is a good safety mechanism otherwise i can use any email address and spam the web app by creating multiple accounts which dont belong to me

ebma commented 11 months ago

I think this is a good safety mechanism otherwise i can use any email address and spam the web app by creating multiple accounts which dont belong to me

Hmm okay. You are totally right that it's a good safety mechanism, I was just concerned because it increases the effort of this signup by 2-3x. But we can try.

TorstenStueber commented 11 months ago

See my remarks in the login ticket: https://github.com/pendulum-chain/pendulum-pay/issues/4#issuecomment-1842039924

I see particularly that the following things should be changed:

prayagd commented 11 months ago

@TorstenStueber update done to the main description, will create new tickets for the for a feature we will implement later

TorstenStueber commented 11 months ago

@prayagd thanks, please also link to the new ticket(s) here.

TorstenStueber commented 7 months ago

@prayagd we should move this to icebox.

TorstenStueber commented 7 months ago

This ticket is meant for an obsolete prototype. Closed.