Phase 4 - Prototype: Add BRL off ramp support

pendulum-chain / vortex

1 stars 0 forks source link

Phase 4 - Prototype: Add BRL off ramp support #24

Closed vadaynujra closed 4 months ago

vadaynujra commented 4 months ago

Context

Following the successful off-ramping of BRL tokens via Ntokens, we now have a way to off ramp to Brazillian bank account.

Requirement

Add support for BRL off-ramping via Ntokens, to the current version of the prototype, similar to adding EUR off-ramp support via MYKOBO.

References

Developer documentation from Ntokens: https://www.ntokens.com/developers
Asset details on Stellar: https://stellar.expert/explorer/public/asset/BRL-GDVKY2GU2DRXWTBEYJJWSFXIGBZV6AZNBVVSUHEPZI54LIS6BA7DVVSP-1
See also the changes made in PR https://github.com/pendulum-chain/prototypes/pull/2

vadaynujra commented 4 months ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

vadaynujra commented 4 months ago

@TorstenStueber any other details to be specified in this ticket?

ebma commented 4 months ago

I added a link to the PR that added support for BRL to the CLI prototype, this should be good enough.

@vadaynujra do you have some suggestions for the UX here though? How would you expect to choose between EURC or BRL?

TorstenStueber commented 4 months ago

Let's maybe just use the simplest solution: two buttons, one that start the EURC offramp, the other starts BRL offramp. We can think about better UX at a later iteration.

prayagd commented 4 months ago

@gianfra-t i have added some smaller text changes in the ticket description based on the feedback we received from the earlier phases testing. Can you please included these changes in this phase?

prayagd commented 4 months ago

Agree to @TorstenStueber solution

ebma commented 4 months ago

Text changes were moved to extra ticket https://github.com/pendulum-chain/pendulum-pay/issues/27, I changed the description of this ticket again.

gianfra-t commented 4 months ago

I believe as of now BRL was tested but EURC not yet ? Maybe we can close this once both are tested.

prayagd commented 4 months ago

@vadaynujra can you please test EURC too?

vadaynujra commented 4 months ago

Off ramp to EUR bank account completed successfully. Think this link should be enough to evidence and link all related transactions?

gianfra-t commented 4 months ago

Thanks @vadaynujra! I will close this one now since both paths were tested.