search

pendulum-chain / vortex

1 stars 0 forks source link

Phase 3.1 text changes #28

Closed ebma closed 4 months ago

ebma commented 4 months ago

Closes #27.

netlify[bot] commented 4 months ago

Deploy Preview for pendulum-pay ready!

Name Link
Latest commit c024bf6602ae72b55e1c7ae7c190ce055f30dd0d
Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/663a56442389ce0008a68fe0
Deploy Preview https://deploy-preview-28--pendulum-pay.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ebma commented 4 months ago

@prayagd I added you as the reviewer as this only contains text changes so it should be fine if you have a look at the files changed. Note that I added numbering to some texts, ie. "1. Prepare Prototype", "2. Enter bank details", and "3. Start Offramping" because that's how it was phrased in the feedback. If you removed those numbers on purpose in the description, I can also change it again for the prototype.

prayagd commented 4 months ago

Note that I added numbering to some texts, ie. "1. Prepare Prototype", "2. Enter bank details", and "3. Start Offramping" because that's how it was phrased in the feedback. If you removed those numbers on purpose in the description, I can also change it again for the prototype.

i thought the numbering was for feedback purpose, personally find it confusing to number the buttons. Because if we have to then Connect wallet should be 1. Checking with alex.

ebma commented 4 months ago

I considered this approved based on feedback from Slack. Will merge now.