pendulum-chain / vortex

https://app.vortexfinance.co/
1 stars 1 forks source link

Fix `account_address` parameter sometimes emitted with '' in GA event #293

Closed ebma closed 1 day ago

ebma commented 1 day ago

Context

The account_address parameter emitted as part of the 'GA4 event | wallet_connect' is sometimes just '' which breaks the integration in GA. This seems to happen when connecting to an account, reloading the page, and disconnecting from it. The parameter was introduced in https://github.com/pendulum-chain/vortex/pull/255.

TODO

Change the code so that the event is not emitted without that parameter.