Closed TorstenStueber closed 2 months ago
yarn.lock
changesStatus | Count |
---|---|
456 | |
99 | |
2 | |
6 |
Name | Link |
---|---|
Latest commit | 21b8d706684eeca7267d6c919cc0d624650d0fce |
Latest deploy log | https://app.netlify.com/sites/pendulum-pay/deploys/666f8c854221bb0008114c66 |
Deploy Preview | https://deploy-preview-44--pendulum-pay.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I got an error when trying to offramp BRL. This happened after clicking on the 'Enter bank details' button which afterwards changed to 'Start offramping'. In case we get an error when trying to enter bank details, we should prevent the user from continuing.
Clicking on the 'Start offramping' button after receiving the error, will log the following errors into the console.
I get the same error when trying to offramp EURC with Mykobo.
@ebma It seems that also your second screenshot is an nTokens offramp, not a Mykobo offramp.
I just tested again and confirm that Mykobo works.
For nTokens the reason for the failure is that they changed their minimum offramp amount from 1 BRL to 200 BRL, must have happened just in the last few days. I changed the min amount in the configuration accordingly.
Additionally I fixed two unrelated problems I found while testing.
@gianfra-t do you have a chance to also do some review of this PR?
@TorstenStueber will there be any more changes to this one? I was planning to merge it into 6A (working locally) since there are many overlapping changes.
Since many times the swap will be higher than the minimum accepted to off-ramp, those funds will remain on the user's account. Is this acceptable for this version?
@gianfra-t Yes, this is exactly the agreed on behavior for this version.
No more changes planned. I will merge this now.
Closes #36
I also
number
to eitherstring
orBig
Big
is never stringified in exponential notation