search

pendulum-chain / vortex

1 stars 0 forks source link

Flow Continuable Restructure #73

Closed Sharqiewicz closed 1 month ago

Sharqiewicz commented 2 months ago

✅ Changed UI to be compatible with Mykobo SEP24 ✅ Divided huge useMainProcess hook into smaller ones ✅ Use Typescript Record<OperationStatus,...> instead of switch()case due Open-closed principle and to improve readability and maintainability ⚠️ Fixed useEffect dependencies, before dependencies were missing which was causing Stale Closure ⚠️ Don't import react in Preact project, use preact/compat instead

Sharqiewicz commented 2 months ago

@pendulum-chain/devs please review

ebma commented 2 months ago

I'd like to postpone my review until https://github.com/pendulum-chain/vortex/pull/70 is completed which AFAIK is still under development.

gianfra-t commented 2 months ago

@ebma Some of the changes on this PR include also the UI changes for using the sep 24 again, so I think this would be relevant for #70, right @Sharqiewicz ? To be honest I paid most attention to the refactor of the main process hook.

Sharqiewicz commented 2 months ago

Yes, this PR includes the the sep24 for new UI. I think merging this with #70 may cause merge conflicts for the changes from @TorstenStueber. I think we can wait with merging it to make it easier for @TorstenStueber

ebma commented 1 month ago

@Sharqiewicz Since some things changed on the continuable-flow PR, I expect it to be quite annoying to resolve the current merge conflicts on this PR. If you still have a rough idea of the non-hook-refactoring changes you added as part of this, it might be easier for you if you start a new branch based on the current polygon-prototype-staging and re-add the changes to that one instead of trying to fix this one.

Since many hooks were removed in the meantime, that refactoring will not be needed anymore.

TorstenStueber commented 1 month ago

@Sharqiewicz will you follow the recommendation by @ebma? Shall we put this PR on hold then and not ready to review?

Sharqiewicz commented 1 month ago

I think we can abandon this branch. The changes are no longer relevant. @ebma @TorstenStueber Can I close this branch?

ebma commented 1 month ago

Okay let's close it then.