pendulum-chain / vortex

1 stars 0 forks source link

UI fixes for the vortex app #96

Closed Sharqiewicz closed 1 month ago

Sharqiewicz commented 1 month ago

Context


Collecting all the small fixes in this single ticket

Requirements


Implementation


✅ Implemented Simple ERC20 ABI (USDC uses ERC20 ABI) ✅ Implemented verification of user's USDC balance ✅ Update Navigation urls ✅ Update benefits list

netlify[bot] commented 1 month ago

Deploy Preview for pendulum-pay ready!

Name Link
Latest commit bbdd00cded75ce07310993210638f97e2c58900b
Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/66c4acd8c41d3f0008445993
Deploy Preview https://deploy-preview-96--pendulum-pay.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ebma commented 1 month ago

@pendulum-chain/devs please also review this

github-actions[bot] commented 1 month ago

yarn.lock changes

Click to toggle table visibility
| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `pendulum-pay` | [REMOVED](#) | 0.0.0-use.local | - | | `vortex` | [ADDED](#) | - | 0.0.0-use.local |
prayagd commented 1 month ago
Screenshot 2024-08-19 at 12 05 38 PM

@Sharqiewicz can we show the Available Balance below the input field? Otherwise all good

prayagd commented 1 month ago

@Sharqiewicz Also remove the "IBAN" text

TorstenStueber commented 1 month ago

This is now ready to review, I implemented the comments.

I did not remove the IBAN, instead I did this in https://github.com/pendulum-chain/vortex/pull/95.

I repositioned the user balance after the "from amount" field, however, I positioned it to the right. I considered this to make more sense.

prayagd commented 1 month ago

Works as expected, LGTM