pendulum-chain / vortex

https://app.vortexfinance.co/
1 stars 1 forks source link

Switch to Circle EUR.s deployment of Forex AMM for current Vortex version #98

Closed prayagd closed 1 month ago

prayagd commented 3 months ago

Context

Currently vortex uses MYKOBO EUR.s in the backend which is to be demised, this ticket is to switch it to Circle EUR.s

Requirement

prayagd commented 3 months ago

Hey team! Please add your planning poker estimate with Zenhub @ebma @gianfra-t @TorstenStueber @bogdanS98

ebma commented 3 months ago

If I understand correctly, we'd need to modify the existing Nabla deployment or deploy a new one. Modifying the existing one is probably better so we don't have to deposit all the liquidity again. However, I think we should withdraw all the deposited Mykobo EURC from the existing pool before removing it from the Nabla deployment. Or what do you think about how we should approach this @TorstenStueber?

TorstenStueber commented 3 months ago

There is already a Nabla deployment for USDC.axl and EURC Circle:

What is confusing is that we refer to the two Nabla instances on Pendulum as the "USDT" and the "USDC.axl" one. In fact,

So we just need to use the "USDC.axl" instance. You will see that currently all pools are empty and we need to fill them. Then we are good to go.

prayagd commented 2 months ago

@TorstenStueber can you please add your estimates?

TorstenStueber commented 2 months ago

Additionally we need to charge all pools of the Nabla deployment: https://www.notion.so/satoshipay/24-05-16-Nabla-Pendulum-Deployment-c7cefd58f44c428a92ceaea30c603286?pvs=4#8e4f600924684cc1a9f2e1842323dda6

gianfra-t commented 2 months ago

Mykobo does not yet support EURC circle, right? I am looking at their well-known/stellar.toml and it still points to the previous EURC.

So besides charging the pools, we need to wait for them to support this? Or is this file incorrect?

ebma commented 2 months ago

Good question, I never tried. But looking at the blog post, I assume that this feature is already live for some time now. @pendulum-chain/product can you confirm that withdrawing circle EURC with Mykobo is possible? Have you tried that before?

gianfra-t commented 2 months ago

Because so far we only specify the asset code, then there is no way to differentiate between both. Since the offramp account has been the Mykobo EURC one, leads me to think that this is not supported, or at least some extra parameter has to be passed.

For instance, the optional asset_issuer allowed in the sep 24 specs.

ebma commented 2 months ago

Interesting, thanks for sharing. Maybe they support both assets and we can just send either Mykobo EURC or Circle EURC to their endpoint and the result is the same. Could be that they just forgot to update their Stellar.toml file.

Let's wait for a clarification from the product team and if no one tried this before we can reach out on Slack.

gianfra-t commented 2 months ago

Moving to Icebox until we have clarification from Mykobo, or decide to test it anyway.

vadaynujra commented 2 months ago

MYKOBO has explicitly confirmed that they can off ramp Circle's EURC already. I will confirm why their .toml file doesn't already include it @gianfra-t @ebma

vadaynujra commented 2 months ago

For this ticket's pov, we can go ahead and test, taking my confirmation as final for now.

gianfra-t commented 1 month ago

@pendulum-chain/product we can test a EURC.circle based off-ramp in this deployment.