NameError in tags.py

[GoogleCodeExporter]

  File "/home/michael/omg/trunk/stagger/tags.py", line 51, in read_tag
    return cls.read(file, offset)
  File "/home/michael/omg/trunk/stagger/tags.py", line 533, in read
    frame = tag._decode_frame(frameid, bflags, data, i)
  File "/home/michael/omg/trunk/stagger/tags.py", line 552, in _decode_frame
    (flags, data) = self._interpret_frame_flags(bflags, data)
  File "/home/michael/omg/trunk/stagger/tags.py", line 1096, in
_interpret_frame_flags
    raise FrameError("{0}: Unknown frame encoding flags:
0x{1:X}".format(frameid, b))

This happened while I tried to read the tags of one mp3 file, which
probably has some broken tags (hundreds of other files worked well).
However, obviously the names 'frameid' and 'b' are not set in that context.
I didn't dive into that further so I don't have any suggestions.

I am using the last svn version of stagger on linux with python3.1.

Original issue reported on code.google.com by superm...@googlemail.com on 29 Oct 2009 at 2:15

[GoogleCodeExporter]

This issue was closed by revision r74.

Original comment by Karoly.Lorentey on 29 Oct 2009 at 10:51

• Changed state: Fixed

[GoogleCodeExporter]

Thanks for finding this!  If possible, could you please send me a dump of the 
tags in that file?  I’d love to add it 
as a new test case.

Original comment by Karoly.Lorentey on 29 Oct 2009 at 10:53

[GoogleCodeExporter]

Of course ... could you tell me how to easily dump the tag of an mp3 file?

Original comment by superm...@googlemail.com on 30 Oct 2009 at 10:20

[GoogleCodeExporter]

Stagger’s command line tool has an option for dumping tags:

$ stagger --dump track01.mp3 > dump.id3

You can either attach the dump file to this issue, or just email it to 
karoly.lorentey @ gmail.com.  Thanks!

Original comment by Karoly.Lorentey on 30 Oct 2009 at 10:42

[GoogleCodeExporter]

Thanks for the hint, I didn't notice yet that stagger has a command line tool. 
;-)

Original comment by superm...@googlemail.com on 30 Oct 2009 at 11:11

Attachments:

• dump.id3

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Sorry for the last comment, that of course was an error in my own code. ;-)

Original comment by superm...@googlemail.com on 30 Oct 2009 at 11:24

[GoogleCodeExporter]

Thanks for the id3 dump; it turns out that the TENC frame in this tag is 
completely valid!  It just has a "discard 
on file alter" status flag which stagger should've accepted without complaint.

I corrected a typo in the bitmask for the format flag byte, which fixes this 
behavior.  I also added your dump file 
to stagger's test suite.  Thanks again!

Original comment by Karoly.Lorentey on 2 Nov 2009 at 5:11