search

peng-lab / BaSiCPy

MIT License
60 stars 20 forks source link

Multiple Channel Correction #118

Closed Nelson-Gon closed 1 year ago

Nelson-Gon commented 1 year ago

Hi BaSiCPy team,

Awesome package. Looking at this line, I see a comment that for multichannel images, a basic object should be created for each channel.

I am not sure if this comment is for the end user or developers and request clarification on this. If this is intended for the end-user, perhaps there should be some warning if one runs the transform on a multichannel image in case it does affect the result.

Thank you, NelsonGon

yfukai commented 1 year ago

Hi, thanks @Nelson-Gon for pointing this out! I added the warning and updated the docstring at #119. Happy to hear your feedback on that!

Nelson-Gon commented 1 year ago

Looks good, thank you. Closing as it seems resolved in #119