peng-lab / BaSiCPy

MIT License
66 stars 22 forks source link

Add cached flatfield/darkfield values to `basic.predict` #32

Closed Nicholas-Schaub closed 2 years ago

Nicholas-Schaub commented 2 years ago

Currently, predict does not resize the flatfield/darkfield images and will throw an error if input images are not the working_size.

What should happen is the input image size should be compared to the basic.flatfield array, and then basic.flatfield should be stored as basic._flatfield. Subsequent predict calls should check the inputs images against basic._flatfield and basic.flatfield, and if neither matches then resize basic.flatfield and store it in basic._flatfield. The same applies to basic.darkfield.

There are other ways to do this, but the main goal in this approach is to always keep the original, unmodified flatfield and darkfield data. The original flatfield and darkfield data are what should be saved/loaded from disk.