search

peng-lab / BaSiCPy

MIT License
62 stars 20 forks source link

`transform` over `predict` #40

Closed yfukai closed 2 years ago

yfukai commented 2 years ago

When we consider sklearn style, transform and fit_transform seem to be better terms (ex: used for PCA).

Nicholas-Schaub commented 2 years ago

After looking at the description, I agree with this.

I generally dislike rehashing decisions we have made without significant reason, because that opens the door to scrupulosity and slows down the development process. I'm not saying we do this now, but I want to bring this point up now so that we don't fall into a pit.

I think fit/predict works fine, but fit/transform is more appropriate given the sklearn package. I'm okay with either, but I default to leaving it as is.

tdmorello commented 2 years ago

I think transform better describes the operation and is more obvious for the user.

Nicholas-Schaub commented 2 years ago

I think that settles it then. Let's do transform.