Closed yfukai closed 2 years ago
Still not super-ready, but I think the main logic is working fine. I'd be happy to hear feedback.
Please note that experimental_code
will be deleted at the merge.
Dropping Python 3.7 as @jit
of a class fails.
Wrongly closed, reopening!
It seems the tests are not working with the class property changes, but all other parts including baseline calculation are working!
Still not perfect, but I believe the approximate
implementation reproduces the result of the original impl.
Please check this https://github.com/yfukai/BaSiCpy/blob/jax_imprementation/misc_notebooks/compare_with_reference_impl.ipynb
for the details! @tying84 @Nicholas-Schaub @tdmorello
I changed the transform
test a bit to get it working. Not sure I'm going in the correct direction, so please let me know if you would have any comments! @Nicholas-Schaub
This will close #4.
I could add Python 3.7 with setting frozen=True
in pydantic
config. Ready for review for now.
Closing as we merge PRs to #62.
This PR attempts to add