Decide the shape for the `flatfield` and `darkfield`

peng-lab / BaSiCPy

MIT License

62 stars 20 forks source link

Decide the shape for the `flatfield` and `darkfield` #85

Closed yfukai closed 2 years ago

yfukai commented 2 years ago

I think it would be a bit more intuitive if we make basic.flatfield and basic.darkfield the same shape as the input images. We need discussion on this specification.

tdmorello commented 2 years ago

I think that would make more sense. I always saw the reshaping to square as an intermediate step.

yfukai commented 2 years ago

I'll make a PR in this way, thanks!