search

peng-lab / BaSiCPy

MIT License
62 stars 20 forks source link

DCT tools update #98

Closed yfukai closed 1 year ago

yfukai commented 2 years ago

Fix deprecated logic for DCT tools. should be merged later than #95 and #96.

yfukai commented 1 year ago

some test are failing...

yfukai commented 1 year ago 
___________________________ test_inverse_interleave ____________________________

    def test_inverse_interleave():
        x = jnp.arange(24).reshape(4, 3, 2)

        for axis in range(x.ndim):
>           y = jax._src.scipy.fft._dct_interleave(x, axis=axis)
E           AttributeError: module 'jax' has no attribute '_src'

maybe because of JAX update?

yfukai commented 1 year ago

even the dev test are failing after update...

yfukai commented 1 year ago

I fixed the test problems (by changing the way of importing jax hidden functions and loosening np.isclose a bit). Can you check this again? @Nicholas-Schaub

yfukai commented 1 year ago

Maybe we should consider merging jax things in the original repo so that it can follow the changing APIs. At this moment I just fixed the dependency version for safety.

yfukai commented 1 year ago

@Nicholas-Schaub