pengkong / A3M-for-CodeIgniter-2.0

A3M Peanutbutter - For CodeIgniter 2.0
Other
109 stars 84 forks source link

facebook_helper.php #18

Closed SamoSlaus closed 11 years ago

SamoSlaus commented 11 years ago

Well there's something wrong with facebook_helper.php . The code is double and after removig double code i traced error to this $metadata = $this->getMetadataCookie();

after renaming getMetadataCookie() to getMetadataCookieName() I get this error:

Message: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object

donjakobo commented 11 years ago

Good catch on the duplicate code @SamoSlaus . I've cleaned up the code that was duped, do you have a fix for the error you presented (I haven't had the time to do a test of this yet).

SamoSlaus commented 11 years ago

Well indeed i have a fix. I commented this line of code $base_domain = $this->getBaseDomain(); and now its working like a charm.

donjakobo commented 11 years ago

@SamoSlaus, why is 'commenting' this out a solution tho? I haven't had this error before and I've used an (minus the duplication) identical facebook_helper.php file

SamoSlaus commented 11 years ago

Maybe you forgot to write a function called getMetadataCookie() or is this just a typo? Couse there is a function calledgetMetadataCookieName().

donjakobo commented 11 years ago

@SamoSlaus, facebook_helper.php is a direct copy from the Facebook SDK library, nothing was modified by hand (or should not have been, if it got snuck in there, which I highly doubt).