pengowen123 / cge

An implementation of the CGE neural network encoding, written in Rust.
Apache License 2.0
3 stars 2 forks source link

updated version from 2015 to 2018 #1

Closed MathisWellmann closed 4 years ago

MathisWellmann commented 4 years ago

using Rust version 2018 and fixed the resulting errors, no logical changes to the library just refactoring

pengowen123 commented 4 years ago

Thanks for the contribution! I noticed a few small things, but overall this looks good :+1:

MathisWellmann commented 4 years ago

Thanks for actively looking at my PR. I'm rather new to creating pull request to other repos and originally only intended to merge the first two commits but apparently once I added more commits to my own fork it shows up here as well. regardless I kind of like all the commits as it pretty much just extends the Activation enum to more functions and provides useful methods. With the last commit I resolved your suggestions and it should hopefully be ready to merge.