search

penguin-teal / gnome-openweather

A GNOME Shell extension to show the weather of any location on Earth.
GNU General Public License v3.0
57 stars 17 forks source link

Small visual UI issue when hovering over action Icons #28

Open andy-page-developer opened 6 months ago

andy-page-developer commented 6 months ago

First of all LOVE the extension.

Just got a silly little UI issue.

In Fedora 40 and Gnome 46.1 when I open the weather pane, if I hover over the action icons, the pane shifts a little.

I've recorded a little video to show you.

https://drive.google.com/file/d/1E3fHtg1G-boGrbE-c1c4pudYH_9JFRe1/view

It's nothing major.

penguin-teal commented 6 months ago

@andy-page-developer thanks for the bug report. Are you using an extension for the panel on the bottom of your screen?

andy-page-developer commented 6 months ago

@penguin-teal so sorry for not providing better diagnostic inf.

Yes the "taskbar" is a Gnome Extension

https://github.com/home-sweet-gnome/dash-to-panel https://extensions.gnome.org/extension/1160/dash-to-panel/

I've also pasted my Exported Settings in case that helps.

If you need any more info please don't hesitate to ask

[/]
animate-app-switch=false
animate-appicon-hover=false
animate-appicon-hover-animation-extent={'RIPPLE': 4, 'PLANK': 4, 'SIMPLE': 1}
animate-window-launch=false
app-ctrl-hotkey-1=['<Control><Super>1']
app-ctrl-hotkey-10=['<Control><Super>0']
app-ctrl-hotkey-2=['<Control><Super>2']
app-ctrl-hotkey-3=['<Control><Super>3']
app-ctrl-hotkey-4=['<Control><Super>4']
app-ctrl-hotkey-5=['<Control><Super>5']
app-ctrl-hotkey-6=['<Control><Super>6']
app-ctrl-hotkey-7=['<Control><Super>7']
app-ctrl-hotkey-8=['<Control><Super>8']
app-ctrl-hotkey-9=['<Control><Super>9']
app-ctrl-hotkey-kp-1=['<Control><Super>KP_1']
app-ctrl-hotkey-kp-10=['<Control><Super>KP_0']
app-ctrl-hotkey-kp-2=['<Control><Super>KP_2']
app-ctrl-hotkey-kp-3=['<Control><Super>KP_3']
app-ctrl-hotkey-kp-4=['<Control><Super>KP_4']
app-ctrl-hotkey-kp-5=['<Control><Super>KP_5']
app-ctrl-hotkey-kp-6=['<Control><Super>KP_6']
app-ctrl-hotkey-kp-7=['<Control><Super>KP_7']
app-ctrl-hotkey-kp-8=['<Control><Super>KP_8']
app-ctrl-hotkey-kp-9=['<Control><Super>KP_9']
app-hotkey-1=['<Super>1']
app-hotkey-10=['<Super>0']
app-hotkey-2=['<Super>2']
app-hotkey-3=['<Super>3']
app-hotkey-4=['<Super>4']
app-hotkey-5=['<Super>5']
app-hotkey-6=['<Super>6']
app-hotkey-7=['<Super>7']
app-hotkey-8=['<Super>8']
app-hotkey-9=['<Super>9']
app-hotkey-kp-1=['<Super>KP_1']
app-hotkey-kp-10=['<Super>KP_0']
app-hotkey-kp-2=['<Super>KP_2']
app-hotkey-kp-3=['<Super>KP_3']
app-hotkey-kp-4=['<Super>KP_4']
app-hotkey-kp-5=['<Super>KP_5']
app-hotkey-kp-6=['<Super>KP_6']
app-hotkey-kp-7=['<Super>KP_7']
app-hotkey-kp-8=['<Super>KP_8']
app-hotkey-kp-9=['<Super>KP_9']
app-shift-hotkey-1=['<Shift><Super>1']
app-shift-hotkey-10=['<Shift><Super>0']
app-shift-hotkey-2=['<Shift><Super>2']
app-shift-hotkey-3=['<Shift><Super>3']
app-shift-hotkey-4=['<Shift><Super>4']
app-shift-hotkey-5=['<Shift><Super>5']
app-shift-hotkey-6=['<Shift><Super>6']
app-shift-hotkey-7=['<Shift><Super>7']
app-shift-hotkey-8=['<Shift><Super>8']
app-shift-hotkey-9=['<Shift><Super>9']
app-shift-hotkey-kp-1=['<Shift><Super>KP_1']
app-shift-hotkey-kp-10=['<Shift><Super>KP_0']
app-shift-hotkey-kp-2=['<Shift><Super>KP_2']
app-shift-hotkey-kp-3=['<Shift><Super>KP_3']
app-shift-hotkey-kp-4=['<Shift><Super>KP_4']
app-shift-hotkey-kp-5=['<Shift><Super>KP_5']
app-shift-hotkey-kp-6=['<Shift><Super>KP_6']
app-shift-hotkey-kp-7=['<Shift><Super>KP_7']
app-shift-hotkey-kp-8=['<Shift><Super>KP_8']
app-shift-hotkey-kp-9=['<Shift><Super>KP_9']
appicon-margin=0
appicon-padding=8
appicon-style='NORMAL'
available-monitors=[0]
dot-color-dominant=true
dot-color-override=false
dot-color-unfocused-different=false
dot-position='BOTTOM'
dot-size=1
dot-style-focused='DASHES'
dot-style-unfocused='SOLID'
focus-highlight-color='#3d3846'
hotkeys-overlay-combo='TEMPORARILY'
intellihide-key-toggle=['<Super>i']
leftbox-padding=-1
panel-anchors='{"0":"MIDDLE"}'
panel-lengths='{"0":100}'
panel-positions='{"0":"BOTTOM"}'
panel-sizes='{"0":40}'
primary-monitor=0
shortcut=['<Super>q']
show-apps-icon-file=''
show-favorites=true
show-running-apps=true
status-icon-padding=-1
trans-use-custom-bg=false
trans-use-custom-opacity=true
tray-padding=-1
window-preview-title-position='TOP'
penguin-teal commented 6 months ago

I think it is your user theme or possibly even Dash to Panel causing the issue (although I tried the extension and it worked fine). I don't have any events set on hover, and the buttons and visuals are just part of the Clutter library which is part of the GNOME Shell. Therefore, there's not really anything I can do about this; make sure your user theme, GNOME shell, etc. is up to date.

andy-page-developer commented 6 months ago

Thanks very much. I'll investigate further. It was just that this was the only thing on my taskbar that was doing this when hovering over icons. But I'll see what I can do.

Thank you for your time

andy-page-developer commented 6 months ago

Hi Again.

I've just done a clean install of Fedora 40 / Gnome 46 (Using Xorg/X11 not wayland) and I've disabled all the extensions except for OpenWeather. Updated everything to latest version an hour ago.

I'm not using any themes. This is out of the box clean etc.

It's still doing the same thing, albeit now in the topbar.

Video https://watch.screencastify.com/v/oJ48OP3Ro8tVQCw1Ax4g

Screenshot from 2024-05-05 11-00-06

Here is the About section.

System Details Report

Report details

Hardware Information:

Software Information:

penguin-teal commented 6 months ago

I'll investigate the Clutter API a little more but this might be something that I am unable to fix. Thanks for running more tests, I'll try it in the environment you say.

andy-page-developer commented 6 months ago

No problem. Its very minor, just one of those silly annoyances.

Shout if you need to me to do any testing for you.

penguin-teal commented 6 months ago

Reproduced on Fedora Workstation 40. The issue seems to be that the hover effect on the buttons by the theme increases the padding. This only seems to happen in Clutter and not GTK. I'll think of a solution and might make a bug report to GNOME because I can't see this ever being good thing.

andy-page-developer commented 6 months ago

Ah that's great. glad to know I wasn't going mad :)

penguin-teal commented 6 months ago

Mutter Issue #3470

ferdnyc commented 5 months ago

@penguin-teal

This remains labeled "Invalid", is that still correct? (It's an upstream bug, sure, but it's a valid one that even has a repro.)

penguin-teal commented 4 months ago

Update: Issue has been moved from Mutter issues to Gnome Shell #7726 (although still no response/progress).

odimn commented 1 week ago

The only way to bypass this visual issue i found is to change the padding in the stylesheet.css file. In lines 6 to 8 .openweather-button:hover padding: 14px; i have changed it to 13px; and in lines 163 to 166 .openweather-button-action:hover, .openweather-button-action:focus { border: none; padding: 11px; changed it to 10px. Arch Linux / Gnome 47 / Wayland.