search

penguin-teal / gnome-openweather

A GNOME Shell extension to show the weather of any location on Earth.
GNU General Public License v3.0
58 stars 18 forks source link

Contrast too low #3

Closed bleper closed 10 months ago

bleper commented 10 months ago

The high contrast option only works for a small number of elements and requires manual selection for light or dark mode, which is not suitable for automatic theme changing situations where the text may become completely unreadable

Such a gray is difficult to read even with a custom black background, it is not entirely clear why not use the default text color

penguin-teal commented 10 months ago

Thanks for reporting the issue! The color is determined by your shell theming, not the extension. A issue for high contrast was started on an old fork of the project, where Jason Oickle said it was determined by the shell and not able to be overridden, and he refused to add the feature. I have added the feature as a "hack." I can make it affect all the text, however I can't adjust for "automatic theme changing situations" and I can only program in constant colors as far as I know. I will make high contrast affect the entire pop-up in v128.

penguin-teal commented 10 months ago

Fixed, will be shipped with v128 soon.