search

penguin86 / ojo

Ojo is a basic RTSP IP Camera surveillance wall for Android
GNU General Public License v3.0
68 stars 15 forks source link

Single Stream in Portrait #1

Open BadCo-NZ opened 2 years ago

BadCo-NZ commented 2 years ago

Hi @penguin86,

Nice work on the app, I appreciate you specifically making a FOSS app for f-droid :)

I grabbed this app to use on a spare tablet as a baby monitor, and after some testing it works well for this. However, after setting up the camera in it's final place, I ended up rotating the stream. Now the stream is displayed in portrait while the app is in landscape, which means the stream is a third of the size it could be, with big black boxes either side of the stream.

Is there a way of changing the app to be in portrait mode?

If not, are you able to add the function of rotation or to be able to select landscape or portrait?

Thanks again, BadCo.

penguin86 commented 2 years ago

Hi @BadCo-NZ, thank you for using the app. The app was sketched in a day of work, as I needed it for a talk at the last Linux day, so is in its earliest stages of development. I decided to lock the orientation in portrait to simplify the development, especially in the tiles view. BTW, I may move the full screen view on its own activy and unlock the orientation just for that one, this should fix the problem while keeping the current tiles view. Unfortunately I'm pretty busy ATM, but I'll work on this issue and let you know when I'll have a working version.

Have a nice day! Daniele

BadCo-NZ commented 2 years ago

Hey @penguin86

Thanks for the quick reply.

BTW, I may move the full screen view on its own activy and unlock the orientation just for that one, this should fix the problem while keeping the current tiles view.

That sounds like a quick and easy fix without disrupting the tiling view.

Unfortunately I'm pretty busy ATM, but I'll work on this issue and let you know when I'll have a working version.

No worries, it still works for me now, I just have to squint at the tablet a bit :D

I look forward to hearing about your progress, but no pressure!

penguin86 commented 2 years ago

Hi @BadCo-NZ, I implemented the rotation (defaults to disabled, but can be enabled in settings screen) in version 0.1.0. It should work, but I couldn't find a portrait stream to test it. I'm testing it a bit before releasing the new version, so it may need some days before landing on F-Droid. Leaving this issue open for now.

BadCo-NZ commented 2 years ago

Awesome @penguin86, that's great news!

Let me know if you want a hand testing :)

penguin86 commented 2 years ago

Hello @BadCo-NZ! I just released the new version, if you'd like to test it: https://github.com/penguin86/ojo/releases/tag/v0.1.0 Keep in mind that this version is signed with my dev key, so Android will prevent upgrading from the F-Droid version. Anyway I also tagged the release, so as soon as the F-Droid build system will trigger, the release will be available as well there. It may need a couple of days. Thank you!

BadCo-NZ commented 2 years ago

Nice one @penguin86

I just did a quick test on my phone. For daily usage I have the screen rotation fixed to portrait, but when using the app and enabling screen rotation within the app it overrides my phones settings and allows auto rotate.

Do you think it would be better to just have a toggle for landscape or portrait? This would work better for how I use the app, on a static spare device. Not sure about other use cases though :)