:bug: WebSocket connection does not detect link failures - Githubissues

penguineer / Rabbarkable

RabbitMQ (AMQP) connector for the reMarkable API

https://hub.docker.com/r/mrtux/rabbarkable

MIT License

5 stars 0 forks source link

:bug: WebSocket connection does not detect link failures #15

Open penguineer opened 2 years ago

penguineer commented 2 years ago

The WebSocket connection to receive notifications does not always detect disconnects from the server.

To reproduce:

Initiate a connection
Make sure it is working by creating events on the reMarkable tablet
Not let the machine with Rabbarkable running sleep for > 5 minutes
Bring the machine back up

Expectation:

NotificationClient will get a call on onClosed
Heartbeat processing will detect an invalid connection

What actually happens:

The connection is recognized as being valid
Heartbeats are being sent without error
Notifications are no longer received

For a production environment sleep mode is a very unlikely scenario, but I am not sure how this behavior also applies to other connection errors.