search

pengutronix / meta-ptx

Yocto layer for ptx-releated tools and distro
MIT License
10 stars 23 forks source link

genimage: added missing 'mtools' dependency. #129

Closed benjamin1313 closed 7 months ago

benjamin1313 commented 8 months ago

Ran into an issue where mcopy was missing. This should make sure mtools is on the host machine before building genimage.

ejoerns commented 7 months ago

@benjamin1313 Could you point out where you need 'mcopy' for building genimage?

I can only see the build test suite where it is used, but it should be optional there.

benjamin1313 commented 7 months ago

I'm creating an image with a vfat partition and get an error with mcopy: command not found I can see mcopy is used when creating a vfat image in your genimage repo, and adding mtools as a dependency helps fix the problem with mcopy not being found. mcopy-error https://github.com/pengutronix/genimage/blob/0d9f20716932bb2121bcddfe9ab92ec9b637dc58/image-vfat.c#L65

ejoerns commented 7 months ago

@benjamin1313 This is not a problem with building genimage but with using it. Thus an 'mcopy' build dependency is not the proper fix here.

Since without parsing the genimage config one cannot easily know beforehand which tools will be required by a genimage-based image recipe, the best way I see is to add them manually. See

https://github.com/pengutronix/meta-ptx/blob/master/classes-recipe/genimage.bbclass#L26