search

pengwynn / chargify

Ruby wrapper for the chargify.com SAAS and billing API
MIT License
61 stars 29 forks source link

Make hashie dependency pessimistic #9

Closed sj26 closed 11 years ago

sj26 commented 12 years ago

Allows interoperability with chargify2 gem. :-)

cldwalker commented 12 years ago

Modifying hashie makes sense. Not interested in bundler or multi_json. For future ref, multiple issues should be split up into separate pull requests

sj26 commented 12 years ago

Sorry, this pull request was only meant to be the first commit but the rest got pulled in as we updated our branch.

I encountered issues adding tests because the dependency on Crack wasn't stated. Seeing as HTTParty already relies on multi_json which uses some faster json implementations if they're available this seemed like a natural move. Plus, HTTParty does it for you now. :-)

We split out the version because loading the gem to grab the version was failing for us in certain scenarios. It seems to be good practise to have a separate file these days, too.

The bundler stuff was just convenience.

This branch will be updated more eventually when I get to look at it again.

cldwalker commented 11 years ago

Closing since nothing was ever updated and hashie version has been bumped