pengx17 / logseq-dev-theme

</> Logseq dev theme
https://pengx17.github.io/knowledge-garden/
MIT License
370 stars 65 forks source link

bullet_threading: broke line drawing error #95

Closed cybertosher closed 3 months ago

cybertosher commented 1 year ago

After the latest update there are small vertical lines that do not line up properly on Windows 10 machine. This was not the case on Friday, so I assume it is the latest commit to fix items on mobile platforms that did it.

Screenshot 2023-05-15 091018

UNICKCHENG commented 1 year ago

@cybertosher I'm sorry for causing you trouble. The main reason is that Logseq was recently updated to version 0.9.6, which caused compatibility issue(https://github.com/pengx17/logseq-dev-theme/issues/92). This issue seems to have been fixed before(https://github.com/pengx17/logseq-dev-theme/pull/93), but it still appears in your screenshot. Could you please try the following steps to check again?

  1. update logseq-dev-theme to the latest version, v1.26.17.
  2. check if there are any additional configurations in the logseq/custom.css file.
UNICKCHENG commented 1 year ago

If you find this issue still exists, you can try adding the following code to logseq/custom.css and adjusting the value of "left" to fix it.

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

image

cybertosher commented 1 year ago

Greeting! None of these worked for me. I was not using the logseq-dev-theme, I was using Bonofix before this issue started. What I tried was this:

  1. I downloaded the latest dev theme (1.26.17) and verified that the custom.css file was empty. No change.
  2. I selected the dev theme as my active theme, no change.
  3. I added the custom css code above and no change
  4. I deleted Bonofix and ensured that dev theme was the only theme installed, no change
  5. Restarted logseq several times, no change.

So unfortunately I still have the issue with threading not working, but the additional distraction of a theme I don't like as much. 😄 Any ideas when or if this will be fixed, or something else I can try?

Thanks for all of your efforts.

MaxenceG2M commented 1 year ago

Hi!

I have the same problem, but the @UNICKCHENG fix works for me with a really huge value (e.g. -500).

There is a screenshot with a value of -200: image

The last really deep bullets bring back the problem.

HtH

By the way, thank you for your work on this great plugin, one of the most essential for me :)

cybertosher commented 1 year ago

I tried the custom.css code with -250px as the offset, as @MaxenceG2M suggested, and it cleans up the issue for the bullet levels I use. I'm OK with weird artifacts that only happen sometimes.

And I agree, thanks for all of your work @UNICKCHENG on this plugin, it is definitely my favorite.

Vitor12xx commented 1 year ago

I was able to use @UNICKCHENG fix to align the rogue vertical line with -16px as the offset.

Thanks for the fix!

cybertosher commented 1 year ago

Is there going to be a permanent fix anytime soon? Changing my custom.css to -15px solved the issue on my Mac, but this workaround seems a bit arbitrary. Just curious. 😃

UNICKCHENG commented 1 year ago

Is there going to be a permanent fix anytime soon? Changing my custom.css to -15px solved the issue on my Mac, but this workaround seems a bit arbitrary. Just curious. 😃

A more universal solution than this one cannot be found at present, but I believe that this issue will eventually be resolved in the future.

schmy commented 1 year ago

Sorry to trouble you with this minor query, but could you please identify which line in the CSS describes the horizontal line for the child? image

I have already amended the line mentioned above ("ls-block ... -21 px"), but I cannot work out which other line draws to the dot point of the child lines.

Thanks in advance!

ericz15 commented 1 year ago

Hi, I encountered the same issue and wanted to share my custom.css file:

@import url("https://cdn.jsdelivr.net/gh/sokirill/logseq-panic-theme@main/custom.css");

:root {
    --ct-code-font-family: Maple Mono, Fira Code, Monaco, Menlo, Consolas, 'COURIER NEW', "等距更纱黑体 SC", monospace;
    --ls-font-family: Verdana, 'fira sans', 'segoe UI Emoji', 'sarasa ui sc', sans-serif;
}

#root>div,
html,
body {
    font-family: var(--ls-font-family);
}

:not(pre)>code,
.CodeMirror {
    font-family: var(--ct-code-font-family);
}

I've tried the solution mentioned earlier with left: -21px;, but unfortunately, the issue still persists.

image

Thank you for your attention to this matter.

Update: I tried left: -15px;, and it works for me.

ginko-ai commented 1 year ago

I have similar issue, (luv the plug-in btw) Screenshot 2023-05-21 084244

UNICKCHENG commented 1 year ago

Sorry to trouble you with this minor query, but could you please identify which line in the CSS describes the horizontal line for the child? image

I have already amended the line mentioned above ("ls-block ... -21 px"), but I cannot work out which other line draws to the dot point of the child lines.

Thanks in advance!

@schmy Try modifying the value of "right" like right: 50px ?

.ls-block > div > div.items-center::before {
    right: 10px !important;
}

image

UNICKCHENG commented 1 year ago

I have similar issue, (luv the plug-in btw) Screenshot 2023-05-21 084244

@ginko-ai , the issue appearing in your screenshot seems to be related to the CSS configuration of the plugin being overridden, which is causing it not to work correctly. Please refer to the following method for troubleshooting.

  1. update logseq-dev-theme to the latest version, v1.26.17.
  2. check if there are any additional configurations in the logseq/custom.css file.
cybertosher commented 1 year ago

Just an update: for some reason my logseq at work does not automatically update. I manually updated to logseq version 0.9.6, applied the -21px offset in custom.css and now everything draws correctly.

Zhangwuhao commented 1 year ago

I have similar issue, (luv the plug-in btw) Screenshot 2023-05-21 084244

I have the same quesiton and how to solve this?

UNICKCHENG commented 1 year ago

I have similar issue, (luv the plug-in btw) Screenshot 2023-05-21 084244

@ginko-ai , the issue appearing in your screenshot seems to be related to the CSS configuration of the plugin being overridden, which is causing it not to work correctly. Please refer to the following method for troubleshooting.

  1. update logseq-dev-theme to the latest version, v1.26.17.
  2. check if there are any additional configurations in the logseq/custom.css file.

@Zhangwuhao here ? If there are still errors, could you provide screenshots and configuration information?

Strubbl commented 1 year ago

I have a similar issue:

grafik

I have no content in logseq/custom.css. This issue was fixed for me, when i installed the plugin Bullet threading. So i can reproduce the issue by deactivating that plugin.

reprintsev commented 1 year ago

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.

Adding this code to the custom.css did not help

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

but if I change the value of the left from -21px to -13px then the problem disappears.

I don't know how correct this is, but I did it and it works:

.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}
DreamWaterFound commented 1 year ago

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17.

Adding this code to the custom.css did not help

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

but if I change the value of the left from -21px to -13px then the problem disappears.

I don't know how correct this is, but I did it and it works:

.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}

Thanks! I also have tried to adjust the left offset but seems bad. This is work for me. Do not display the vertical dash is work for me.

DreamWaterFound commented 1 year ago

Got the same problem after updating Logseq to version 0.9.9. Theme version v1.26.17. Adding this code to the custom.css did not help

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -21px;
}

but if I change the value of the left from -21px to -13px then the problem disappears. I don't know how correct this is, but I did it and it works:

.ls-block[haschild] > div > .block-content-wrapper::before {
  display: none;
}

Thanks! I also have tried to adjust the left offset but seems bad. This is work for me. Do not display the vertical dash is work for me.

Sorry, I need to apologize for my arbitrary conclusion. The method above eliminates the display of vertical lines, which exposes an issue on pages with title text. Below is the erroneous display with vertical lines:

Screenshot from 2023-06-26 15-51-04

Whereas the following is the result with the vertical lines removed:

Screenshot from 2023-06-26 15-50-53

So in the end, I still need to adjust the left offset. At the same time, I noticed an issue with the curve and bullet points not aligning closely. Thanks to @UNICKCHENG, I referred to this reply and used the following code in logseq/custom.css to achieve a nearly perfect effect:

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -13px;
}
.ls-block > div > div.items-center::before {
    right: 10px !important;
}

Screenshot from 2023-06-26 15-56-01

I hope my experience is helpful to someone.


OS: ubuntu 20.04 Logseq: 0.9.9 logseq-dev-theme: 1.26.17

UdeRecife commented 11 months ago

EDIT: I managed to solve the issue by tweaking the value even further.

.ls-block[haschild] > div > .block-content-wrapper::before {
      left: -13.8px;
}
cybertosher commented 3 months ago

Broken again. I have logseq 0.10.7 and the latest dev theme, and once again there is a little broken line. No configuration in custom.css. Is the best way to fix this one again to add the custom CSS, or is there an error with the theme maybe that fixes it? I do not have this issue on Windows 10, only MacOS. This is kind of like Whack-A-Mole

OK, so today I learned (I am slow like this) that the dev theme has bullet threading built in, and that I need to use the dev-theme without bullet threading along with the bullet threading plugin. When I do that, I do not have the little extra bit. So the theme is broken, not the plugin. Closing as my bad.

cybertosher commented 3 months ago

The plugin seems to be working fine, my issue is with the theme.