pengx17 / logseq-plugin-tabs

A Logseq plugin which lets you open pages in tabs like working in the browser
MIT License
285 stars 22 forks source link

Tabs plugin not functioning at all #61

Open bobmhughes opened 1 year ago

bobmhughes commented 1 year ago

This is a great plug-in, in fact I can't imaging using Logseq without it, however for some unknown reason, it has stopped functioning on both my Windows & Mac computers. I have the latest version of logseq and the Tabs plug in installed. The first file I click on in recent or favorites opens in a tab, and subsequent files that I click in are not added too open files, but replace the file that was last opened. Any help would be appreciated. Thanks

pengx17 commented 1 year ago

The first file I click on in recent or favorites opens in a tab, and subsequent files that I click in are not added too open files, but replace the file that was last opened.

@bobmhughes I think this is the default behavior. Opening new page action will not add new tabs, but replace the current tab. You will need to hold ctrl (or CMD) key whiling clicking the page link ref.

bobmhughes commented 1 year ago

Thank you for your response that was most helpful.

When I hold down the ctrl key while clicking the page ref link, the corresponding page will indeed open. However, unless I return to the Daily Journal first, subsequent attempts to open additional pages by holding down the ctrl key while clicking the page ref link, the new page opened will replace the last tab/page opened. I don’t know if this is intended behavior of the plug-in or not, but if it is required to return to the daily journal to open additional pages, then I must conclude that the last additional page opened has the cursor focused on it, and therefore is replaced when opening yet an another page.

Thanks again,

Bob

From: Peng Xiao @.> Date: Friday, October 7, 2022 at 1:25 AM To: pengx17/logseq-plugin-tabs @.> Cc: bobmhughes @.>, Mention @.> Subject: Re: [pengx17/logseq-plugin-tabs] Tabs plugin not functioning at all (Issue #61)

The first file I click on in recent or favorites opens in a tab, and subsequent files that I click in are not added too open files, but replace the file that was last opened.

@bobmhugheshttps://github.com/bobmhughes I think this is the default behavior. Opening new page action will not add new tabs, but replace the current tab. You will need to hold ctrl (or CMD) key whiling clicking the page link ref.

β€” Reply to this email directly, view it on GitHubhttps://github.com/pengx17/logseq-plugin-tabs/issues/61#issuecomment-1271280788, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABW5JAD3UQKYISMSD7ZUAQ3WB7M7FANCNFSM6AAAAAAQ7COXYA. You are receiving this because you were mentioned.Message ID: @.***>

pengx17 commented 1 year ago

if it is required to return to the daily journal to open additional pages This sounds like a bug indeed. The plugin should work the same no matter if it is in the journal pages or in a page. Do you have any other plugins that are enabled? If yes, please try disable others, reload the app and try if the plugin still not function well?

bobmhughes commented 1 year ago

I do have other plugins installed, so I did as you suggested and disabled all of them. However, at least on my MacBook Pro M1 running MacOS 12.6 and Logseq 0.8.8 and Tabs 1.17.2, even with all other plugins disabled, I still must return to the Daily Journal between opening more pages on new tabs.

Thanks for your help.

Bob

From: Peng Xiao @.> Date: Friday, October 7, 2022 at 8:13 PM To: pengx17/logseq-plugin-tabs @.> Cc: bobmhughes @.>, Mention @.> Subject: Re: [pengx17/logseq-plugin-tabs] Tabs plugin not functioning at all (Issue #61)

if it is required to return to the daily journal to open additional pages This sounds like a bug indeed. The plugin should work the same no matter if it is in the journal pages or in a page. Do you have any other plugins that are enabled? If yes, please try disable others, reload the app and try if the plugin still not function well?

β€” Reply to this email directly, view it on GitHubhttps://github.com/pengx17/logseq-plugin-tabs/issues/61#issuecomment-1272210252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABW5JAAZ6JX5VB56BCF4BVDWCDRENANCNFSM6AAAAAAQ7COXYA. You are receiving this because you were mentioned.Message ID: @.***>

hiltronrex commented 1 year ago

I can confirm this is happening as described for me as well. I also tried to disable plugins but the issue was still there.

Other plugins i have are

Awesome UIv1.3.8 Automatic format url titlev1.1.0 Journals calendar0.10.5 Sticky Headersv1.4.2 Awesome Linksv1.10.5 GPT-3 OpenAIv1.0.1 Tabsv1.17.2 Block to pagev1.3.0 Link Previewv2.2.5 logseq-wordcount-pluginv1.8

pengx17 commented 1 year ago

πŸ€” I guess it is time to set up an issue reporter in the plugin ... Did you relaunch the app after disabling all other plugins?

hiltronrex commented 1 year ago

Yes. Tried that and it didn't work. Here is a gif of me being able to open pages from journal but not from a page.

Kapture 2022-10-24 at 16 39 45

richardchui commented 1 year ago

This is happening to me as well. Tabs has been working great until a few days ago. Pressing Cmd-Click will replace the content of the current tab. It is only when the Daily Journal is displayed then a new tab will be opened.

pengx17 commented 1 year ago

@richardchui can you please share the list of installed plugins/themes, and custom.css/custom.js you are using if there is any?

richardchui commented 1 year ago

Plugins - Logseq Find and Replace v1.1.0, Journal Calendar v0.10.5, Logseq Markmap v0.2.4, Tags v0.1.2, Tabs v1.18.0 Themes - Dev theme No custom css/js

iMac running Ventura

richardchui commented 1 year ago

1.18.1 seems to have fixed the issue. Thanks!!

pengx17 commented 1 year ago

@richardchui great! Actually I am not sure why it fixed your issue ... πŸ˜…

richardchui commented 1 year ago

I was wrong. It works only right after I restarted Logseq. Issue has not been solved...

jwwang0-0 commented 1 year ago

I had the same issue before. But after updating all my plugins to the newest version, it is working now. Maybe that helps?

feng1o commented 11 months ago

this is happening to me as well. version : v1.19.1 installed plugins:

logseq-agenda/ logseq-awesome-links/ logseq-awesome-styler/ logseq-banners-plugin/ logseq-block-calendar/ logseq-bonofix-theme/ logseq-bullet-threading/ logseq-calendars-plugin/ logseq-dev-theme/ logseq-doc/ logseq-heatmap/ logseq-journals-calendar/ logseq-kanban-plugin/ logseq-link-preview/ logseq-mark-map/ logseq-markdown-table/ logseq-pdf-export-plugin/ logseq-plugin-gpt3-openai/ logseq-random-note/ logseq-tabs/ logseq-tags/ logseq-tocgen/ logseq-todo-master/ logseq-todo-plugin/ logseq-vim-shortcuts/ logseq-wrap/

https://github.com/pengx17/logseq-plugin-tabs/assets/10048132/c5a7d246-be6c-4ee7-b1e9-0686ccffab8f