search

pengx17 / logseq-plugin-tabs

A Logseq plugin which lets you open pages in tabs like working in the browser
MIT License
285 stars 22 forks source link

Tabs name is showing incorrect #88

Closed manvibharat closed 5 months ago

manvibharat commented 9 months ago

Hi This is a a very minor issue. In my system when I open journal page the the Tab shows it as gj . I tried reinstalling the plugin but not luck. I attach the screen shot for the reference. On my other system it works just fine. That is it shows Journals as the tab name.

Screenshot from 2023-09-04 20-04-25

manishjhawar commented 9 months ago

I'm having the exact same issue although the look and feel is different for me:

image

Also sometimes, while the tab title remains the same, the page shows up as a regular page for "gj":

image

nanonandi commented 7 months ago

It happens to me too, when two tabs are open, closing the one takes me to gj page

ksqsf commented 7 months ago

I'm pretty sure this is because of this line:

https://github.com/pengx17/logseq-plugin-tabs/blob/master/src/PageTabs.tsx#L297

It wants to find the text on the journal button of the left bar, but maybe Logseq changed the order of the elements in some version, and the text is no longer the last element but the second element:

image

I will try to submit a patch soon.

Gitbreast commented 6 months ago

Same. After clear cache on 0.10.1, Journal became “gj”. Btw, good work upstairs!

image
ksqsf commented 6 months ago

The upstream seems unresponsive. Meanwhile, you can use this workaround:

  1. View → Toggle Developer Tools.
  2. In the console, copy&paste localStorage.setItem("journalsString", "Journals") and press Enter. Journals here can be replaced by your preferred tab name.
github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 1.19.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: