pengx17 / logseq-plugin-todo-master

A simple plugin to render a progress bar to gather the overall progress of the TODO markers based on the rendering position.
MIT License
123 stars 15 forks source link

Support for block references? #21

Closed s-kyy closed 2 years ago

s-kyy commented 2 years ago

Hi, thanks for the wonderful plugin!

I was wondering if it can also support tasks that come from block references / block embeds. What I like to do is to note tasks in my daily notes and then reference them in a project note, but the way the todo-master plugin works now doesn't allow for that.

Many thanks!

pengx17 commented 2 years ago

I am not exactly sure what you are trying to achieve. Do you think to render a progress over a custom query could help (which is just supported in recent versions)?

s-kyy commented 2 years ago

I am not exactly sure what you are trying to achieve.

Let's say I have a main project note. I make tasks that I want to do throughout the day in my daily note but tag it with the project name. Yes, querying would capture them all, but I also want to be able to reorganize them into major subtasks for the project which is hard to do with a simple query.

What I would like to do is to have block embed or block reference tasks from the daily notes to my main project note which is more organized. In each major subtask, I would be able to see the progress of all the indented tasks + referenced tasks from my other daily pages that I inserted manually.

An alternative application are for those want to have a progress bar on their daily notes, but not all their tasks are from the same day.

One of the reasons why I don't want to move blocks directly is due to the buggy nature of logseq when it comes to moving blocks. If I want to move a block to a new page it often creates a new block-id, resulting in a bunch of broken references. So to avoid that with tasks as well I want to be able to just block reference them instead of moving them to the project page.

Do you think to render a progress over a custom query could help (which is just supported in recent versions)?

If you don't find it worthwhile that's ok too. I'll make do with just from querying.

Thanks for considering it!

pengx17 commented 2 years ago

@s-kyy thanks for the explanation! I will take a look if it is feasible to get content from embedded blocks as well. 👍

waymedev commented 2 years ago

@s-kyy, I added this feature in the 1.10.0 version. Update and try it out.

s-kyy commented 2 years ago

Hi @3attaE ,

It doesn't work for me still. These are the configurations I have tried:

Gives 0 blocks:

- Text... <todo-master>
    - {{embed ((...))}}

Gives 0 blocks

- TODO <todo-master>
    - {{embed ((...))}}

Gives 1 blocks:

- Text <todo-master>
    - TODO ...
    - {{embed ((...))}}

Gives 0 blocks:

- <todo-master> {{embed ((...))}}

Gives 0 blocks:

- <todo-master> ((...))

Maybe there are was another use case that I missed? It still works as intended with query blocks and normal nested todo items.

OS: Windows10 Logseq: v0.7.5 Plugin version: 1.10.0 Note: I closed and reopened logseq after updating the plugin.

waymedev commented 2 years ago

Thank you for your feedback. I didn't realize you use embed references.

A PR has been submitted to fix this. It will release when @pengx17 reviews.

Gives 0 blocks:

- <todo-master> {{embed ((...))}} Gives 0 blocks:

- <todo-master> ((...))

The above way is not supported yet

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.10.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: