search

penkesiva / testprep

Eq Test Prep
0 stars 2 forks source link

Fix feedback UI #11

Closed penkesiva closed 5 years ago

penkesiva commented 5 years ago

A clean feedback fragment to be done

salgubelli commented 5 years ago

Siva, any feedback after changes?

penkesiva commented 5 years ago

After pulling the latest changes, I see the user can send email to equalityempowerment@gmail.com; and I did notice that the email is received successfully. Great! However, the following can be done for better UX [1] After clicking on 'Send' button and choosing the right email app.. its better we fill-in the 'To' email address automatically, which is equalityempowerment@gmail.com [2] After sending email, the control is coming to TestPrep app which is good! but the content can be erased with some sort of a toast, say "Feedback submitted successfully" [3] The description UI element can be beautified so that the text is entered at the starting of the description box. Minor, but may look better [4] Furthermore, can we send feedback without switching to email app?

salgubelli commented 5 years ago

Addressed 1, 3 2 - it's an intent based sending and no feedback on result. TODO for future if other apps are doing the same 4 - there are solutions. TODO for future if other apps are doing the same

penkesiva commented 5 years ago

Verified 1 and 3. Works Ok.