It isn't obvious that storing tokens doesn't work if listing provider credentials in settings.py

pennersr / django-allauth

Integrated set of Django applications addressing authentication, registration, account management as well as 3rd party (social) account authentication.

https://allauth.org

MIT License

9.51k stars 3.03k forks source link

It isn't obvious that storing tokens doesn't work if listing provider credentials in settings.py #3198

Closed numan closed 1 year ago

numan commented 1 year ago

In my settings.py file I have the following setting enabled:

SOCIALACCOUNT_STORE_TOKENS = True

If I provide provider credentials in the settings.py file, rather than a SocialApp object:

SOCIALACCOUNT_PROVIDERS = {
    'google': {
        'APP': {
            'client_id': '123',
            'secret': '456',
            'key': ''
        },
        'AUTH_PARAMS': {
            'access_type': 'offline',
        },
    }
}

SOCIALACCOUNT_STORE_TOKENS has no impact and tokens are not saved. It would be great to document this behavior.

pennersr commented 1 year ago

I am adhering to the debatable principle that keeping open issues around with respect to documentation is not very helpful in improving things. Feel free to submit a pull request...