Open jonathan-s opened 2 weeks ago
Thoughts:
APPS
). unique_together = ("provider", "uid")
which would be impacted.?client_id=1
and ?client_id=2
, how would I be able to make the choice between those two options, and what does it even matter if I choose 1 or 2 ?MultipleObjectsReturned error which doesn't seem to be caught in the views.
That is indeed not caught as this is considered misconfiguration. The only thing that could be done is to catch it and raise an ImproperlyConfiguredException
.
Providers that implement oauth, and thus use a client id, when making that initial login you could support a get parameters to fetch the client_id from there (if available).
That would make it possible to use several providers of the same type without using different sites.
I would also add that currently you'll get a nasty 500 error as
get_app
can throw aMultipleObjectsReturned
error which doesn't seem to be caught in the views.Would you accept a patch for these changes?