pennhanlee / pe

0 stars 0 forks source link

Wrong Error Message #3

Open pennhanlee opened 3 years ago

pennhanlee commented 3 years ago

The error message appears when the following commands are committed

1: addPerson idp/12345 n/mary p/91234567 e/johnd@example.com a/John street,block 123, #01-01 q/2020-10-10 i/false

2: addPerson idp/12346 n/Mary p/91234567 e/johnd@example.com a/John street,block 123, #01-01 q/2020-10-10 i/false

the index of mary is 6

3: editPerson 6 n/mary

image.png

nus-pe-bot commented 3 years ago

Team's Response

This aspect has been covered under the features section page 10. Persons are rejected not only when their Ids are the same, but also if one of the following conditions is met. (1) Having same name and phone (2) Having same name and address. In the example provided, the tester has chosen to add two persons with the same name, phone and email. This has been detected by VirusTracker as described and thus rejected.

Capture.PNG

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree as this issue is written with context to the error message displayed, as shown in the attached image.

This person already exists in the address book is an error message belonging to the original AddressBook3 programme.

The product failed to cover this error with a suitable error message.

for example, deliberately adding a duplicate person using the command: addPerson idp/12348 n/Alex Yeoh p/87438807 e/alexyeoh@example.com a/ Blk 30 Geylang Street 29, #06-40 q/false i/false

image.png

presents a correct error message : This person already exists in the VirusTracker


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]