search

pennhanlee / pe

0 stars 0 forks source link

Email Format able to accept invalid email formats #4

Open pennhanlee opened 3 years ago

pennhanlee commented 3 years ago

Accepted AddPerson command: addPerson idp/12347 n/Richard p/91234567 e/johnd@gmail a/John street,block 123, #01-01 q/false i/false

where .com is not present

image.png

Accepted AddPerson command: addPerson idp/12347 n/Richard p/91234567 e/johnd@gmailcom a/John street,block 123, #01-01 q/false i/false

where there is no . between gmail and com

image.png

nus-pe-bot commented 3 years ago

Team's Response

According to the section below in the UG, there is no requirement for the domain part of the email to have a period or hyphen. Hence the lack of periods in the aforementioned examples in the issue are valid emails.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While it is true that VirusTracker User Guide does not state that a period or hypen is required for a valid email, It is in fact a criteria for a valid email address.

The omission of a top-level domain (.com, .org, etc) will result in an email address not being valid and emails sent to the specified account will not be received.

Hence, perhaps a email validation regex could be used to ensure that email addresses are valid in terms of widely adopted convention such that the functionality serves its purpose instead of being based on what is written in the UG.